Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore -noplugins command arg #459

Merged
merged 2 commits into from
Jun 7, 2023
Merged

Restore -noplugins command arg #459

merged 2 commits into from
Jun 7, 2023

Conversation

catornot
Copy link
Member

this command arg was removed in plugins v2

basically it prevents plugins from being loaded

testing

a batch file to start northstar with -noplugins
noplugins-test.zip
can't upload bat files lol

pg9182
pg9182 approved these changes Apr 26, 2023
View reviewed changes
Copy link
Member

@pg9182 pg9182 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works.

@GeckoEidechse GeckoEidechse changed the title Restore -noplugins commond arg Restore -noplugins command arg Apr 26, 2023
@GeckoEidechse GeckoEidechse mentioned this pull request Apr 26, 2023
Merged
Alystrasz
Alystrasz approved these changes May 10, 2023
View reviewed changes
Copy link
Contributor

@Alystrasz Alystrasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm -noplugins argument doesn't work with current build, and works with this PR.

@pg9182 pg9182 merged commit 9cf27a6 into R2Northstar:main Jun 7, 2023
@catornot catornot deleted the no-plugins-command branch June 7, 2023 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeckoEidechse GeckoEidechse GeckoEidechse left review comments

@pg9182 pg9182 pg9182 approved these changes

@Alystrasz Alystrasz Alystrasz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Northstar Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@catornot @Alystrasz @GeckoEidechse @pg9182